Skip to content

[cxx-interop] Avoid extra copy in CxxConvertibleToCollection #63458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[cxx-interop] Avoid extra copy in CxxConvertibleToCollection #63458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions stdlib/public/Cxx/CxxConvertibleToCollection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,21 @@ public protocol CxxConvertibleToCollection<Element> {
where RawIterator.Pointee == Element

/// Do not implement this function manually in Swift.
mutating func __beginUnsafe() -> RawIterator
func __beginUnsafe() -> RawIterator

/// Do not implement this function manually in Swift.
mutating func __endUnsafe() -> RawIterator
func __endUnsafe() -> RawIterator
}

extension CxxConvertibleToCollection {
@inlinable
internal func forEach(_ body: (RawIterator.Pointee) -> Void) {
var mutableSelf = self
var rawIterator = mutableSelf.__beginUnsafe()
let endIterator = mutableSelf.__endUnsafe()
var rawIterator = __beginUnsafe()
let endIterator = __endUnsafe()
while rawIterator != endIterator {
body(rawIterator.pointee)
rawIterator = rawIterator.successor()
}
withExtendedLifetime(mutableSelf) {}
}
}

Expand Down