[CSGen] Handle recursive use of variable declarations #63505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
It's possible for out-of-scope type variable to be the type of declaration if such declaration is recursively referenced in the body of a closure located in its initializer expression. In such cases type of the variable declaration cannot be connected to the closure because its not known in advance (determined by the initializer itself). Resolves: swiftlang#63455
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
hborla
approved these changes
Feb 9, 2023
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 10, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 10, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
ahoppen
pushed a commit
to ahoppen/swift
that referenced
this pull request
Feb 10, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 11, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 11, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 12, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455
xedin
added a commit
to xedin/swift
that referenced
this pull request
Feb 13, 2023
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455 (cherry picked from commit 8e82f1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for out-of-scope type variable to be the type of declaration
if such declaration is recursively referenced in the body of a closure located
in its initializer expression. In such cases type of the variable declaration
cannot be connected to the closure because its not known in advance
(determined by the initializer itself).
Resolves: #63455