[5.8][CSGen] Detect nested out-of-scope variables in recursive declarations #63642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to swiftlang#63505 Since, when the type is not stated, a variable assumes the type of its initializer that enables out-of-scope variables to be nested inside of some other concrete type i.e. Optional. Resolves: swiftlang#63455 (cherry picked from commit 8e82f1d)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test macOS platform |
hborla
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #63566
Follow-up to #63505
An out-of-scope type variable(s) could appear the type of
a declaration only in diagnostic mode when invalid variable
declaration is recursively referenced inside of a multi-statement
closure located somewhere within its initializer e.g.:
let x = [<call>] { ... print(x) }. It happens because thevariable assumes the result type of its initializer unless
its specified explicitly.
Scope: Multi-statement closures with invalid recursive declarations.
Main Branch PR: [CSGen] Detect nested out-of-scope variables in recursive declarations #63566
Resolves: Assertion failed: (!bool(ActiveChoice)), function ~ConjunctionStep, file CSStep.h, line 967 #63455
Risk: Very low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: #63455
(cherry picked from commit 8e82f1d)