[CSBindings] Solver result builder transformed closures as soon as all contextual information becomes available #63677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information would be used to decide whether conjunction that represents transformed closure should be delayed or not.
…nts an opaque type
…nsformed closures If a result builder transformed closure doesn't rely on any external type information it could be solved right after it's resolved. We determine that based on three criteria: - Builder type doesn't have any unresolved generic parameters; - Closure doesn't have any parameters; - The contextual result type is either concrete or opaque type.
… parameters are bound Instead of allowing only disjunctions with no parameters, let's use a contextual type to determine whether all of the parameters have been inferred.
…clarations Instead of checking that there are no references to external declarations, let's check that all of such declarations have their types resolved.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please build toolchain |
xedin
force-pushed
the
dont-delay-result-builder-conjunctions
branch
from
b5a8e6a to
b84d70b
Compare
|
@swift-ci please test |
hborla
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determine that based on four criteria:
If all the criteria a met the conjunction that represents a closure is going to be picked and solved as the next solver step.