[5.8][CSBindings] Solver result builder transformed closures as soon as al… #63756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l contextual information becomes available We determine that based on four criteria: - Builder type doesn't have any unresolved generic parameters; - Contextual type associated with the closure doesn't have any unresolved type variables (which means that all possible contextual information is provided to the body); - All of the references to declarations from outer scope are resolved (i.e. a variable declaration from a parent closure); - The contextual result type is either fully resolved or opaque type. If all the criteria a met the conjunction that represents a closure is going to be picked and solved as the next solver step. Resolves: rdar://104645543 (cherry picked from commit f27369d) (cherry picked from commit a815de7) (cherry picked from commit 38f8be1) (cherry picked from commit 5bb9d75) (cherry picked from commit fda7530) (cherry picked from commit b84d70b)
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS platform |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l contextual information becomes available
Cherry-pick of #63677
Improves performance when expressions have both single-statement closures
and result builder transformed closures by solving the latter independently from
the former when possible.
We determine that based on four criteria:
unresolved type variables (which means that all possible contextual information is provided to the body);
If all the criteria a met the conjunction that represents a closure is going to be
picked and solved as the next solver step.
Scope: Result builder transformed closures.
Main Branch PR: [CSBindings] Solver result builder transformed closures as soon as all contextual information becomes available #63677
Resolves: rdar://104645543
Risk: Low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://104645543
(cherry picked from commit f27369d)
(cherry picked from commit a815de7)
(cherry picked from commit 38f8be1)
(cherry picked from commit 5bb9d75)
(cherry picked from commit fda7530)
(cherry picked from commit b84d70b)