[5.8][BuilderTransform] Rework missing buildWithLimitedAvailability detection
#63807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all of the branches of an `if` statement are joined together and hence produce the same type, that type should be used to check whether `buildWithAvailability` is required but missing regardless of availability condition kind. Resolves: swiftlang#63764 (cherry picked from commit c4ea02c)
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #63768
Fixes a crash in diagnostic code that is trying to determine
whether
buildWithLimitedAvailabilityshould be added tothe result builder.
Since all of the branches of an
ifstatement are joinedtogether and hence produce the same type, that type
should be used to check whether
buildWithLimitedAvailabilityis required but missing regardless of availability condition kind.
Scope: Result builder transformed closures/functions with
if #unavailablestatements withoutelsebranch.Main Branch PR: [BuilderTransform] Rework missing
buildWithLimitedAvailabilitydetection #63768Resolves: rdar://105734854
Risk: Very Low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://105734854
Resolves: #63764 (cherry picked from commit c4ea02c)