Skip to content

Fix Test in Release Build #63823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix Test in Release Build #63823

merged 1 commit into from
Feb 22, 2023

Conversation

kyulee-com
Copy link

This fixes ninja check-swift-validation in the Release+Distribution build as the block name is set under #ifndef NDEBUG.

This fixes `ninja check-swift-validation` in the Release+Distribution build as the block name is set under `#ifndef NDEBUG`.
@kyulee-com kyulee-com requested a review from ktoso as a code owner February 22, 2023 05:44
@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

Thanks, I actually just finished building a Release build to confirm that's the only silly mistake here -- LGTM and I confirmed that's the only bit here, thanks for the fix!

@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

Resolves rdar://105745598

@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

@swift-ci please smoke test and merge

@ktoso ktoso requested a review from glessard February 22, 2023 06:16
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Feb 22, 2023
@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

The unrelated failure should be resolved by swiftlang/swift-integration-tests#108

@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

@swift-ci please smoke test Linux

@ktoso
Copy link
Contributor

ktoso commented Feb 22, 2023

@swift-ci please smoke test MacOS

@glessard
Copy link
Contributor

@swift-ci please smoke test linux platform

@glessard
Copy link
Contributor

swift-integration-tests is still failing the smoke test, but this occurs later than what's changed in this PR.

@glessard glessard merged commit 25c2c37 into swiftlang:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants