[5.8] Fix Test in Release Build #63824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `ninja check-swift-validation` in the Release+Distribution build as the block name is set under `#ifndef NDEBUG`.
|
@swift-ci please test |
ktoso
added
the
concurrency
|
Thanks @kyulee-com and @ktoso. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #63823
Description: The test wrongly asserted on
// basic block namewhich are not available in a release build.Risk: Low; test only change, confirmed using a local Release build that the changes are correct and tests pass with them.
Resolves: rdar://105745598
This fixes
ninja check-swift-validationin the Release+Distribution build as the block name is set under#ifndef NDEBUG.Thanks @kyulee-com for the quick fix before I got to it 🙏