Skip to content

build: update build rules for CustomAction removal #64152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Mar 6, 2023

With #63887, the swift compiler can dynamically inject the VFS overlay paths to add the modulemaps and apinotes for the Windows SDK. This obviates the need for the custom action in the SDK installation. Update the build rules to account for this along with swiftlang/swift-installer-scripts#176.

With swiftlang#63887, the swift compiler can dynamically inject the VFS overlay
paths to add the modulemaps and apinotes for the Windows SDK.  This
obviates the need for the custom action in the SDK installation.  Update
the build rules to account for this along with
swiftlang/swift-installer-scripts#176.
@compnerd
Copy link
Member Author

compnerd commented Mar 6, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#176

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Mar 7, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#176

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Mar 7, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#176

@swift-ci please smoke test

@compnerd compnerd merged commit ad1b666 into swiftlang:main Mar 9, 2023
@compnerd compnerd deleted the noca branch March 9, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant