WiX: remove custom action #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the custom action which was used to deploy the auxiliary files. This should no longer be required as the toolchain will now map in the file from the SDK content into the file system image via the VFS layer.
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Mar 6, 2023
With swiftlang#63887, the swift compiler can dynamically inject the VFS overlay paths to add the modulemaps and apinotes for the Windows SDK. This obviates the need for the custom action in the SDK installation. Update the build rules to account for this along with swiftlang/swift-installer-scripts#176.
shahmishal
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the custom action which was used to deploy the auxiliary files. This should no longer be required as the toolchain will now map in the file from the SDK content into the file system image via the VFS layer.