Allow @usableFromInline and @inlinable to package decls #64408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
elsh
requested review from
xymus,
nkcsgexi,
tshortli,
artemcm and
beccadax
and removed request for
xedin,
slavapestov,
hborla and
AnthonyLatsis
elsh
commented
Mar 15, 2023
| @@ -1,3 +1,4 @@ | |||
| // RUN: %target-typecheck-verify-swift -package-name myPkg | |||
There was a problem hiding this comment.
Adding this back (removed in the previous PR); changes to the existing tests in this file are needed to match the original (before the PR)
|
@swift-ci smoke test |
Add tests for packgae inline Add more package acl tests Resolves rdar://104617133
|
@swift-ci smoke test |
|
@swift-ci smoke test |
xymus
approved these changes
Mar 17, 2023
| WARNING(protocol_usable_from_inline_warn,none, | ||
| "protocol %select{refined|used}0 by '@usableFromInline' protocol " | ||
| "should be '@usableForInline' or public", (bool)) | ||
| "should be '@usableFromInline' or public", (bool)) |
There was a problem hiding this comment.
Good catch, I wonder how long that typo was there.
| // RUN: not %target-swift-frontend -typecheck %t/Utils.swift -package-name myLib -I %t 2> %t/resultUtils.output | ||
| // RUN: %FileCheck %s -input-file %t/resultUtils.output -check-prefix CHECK-UTILS | ||
| // CHECK-UTILS: error: class 'PackageKlass' is package and cannot be referenced from an '@inlinable' function | ||
| // CHECK-UTILS: let a = PackageKlass() |
There was a problem hiding this comment.
Can we use the -verify mode and \\ expected-errors to test these? Or maybe move the CHECK lines under the source code raising it if -verify isn't an option? Having the error far from the code makes it hard to follow along.
There was a problem hiding this comment.
Makes sense; will update the test in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow @usableFromInline and @inlinable to package decls
Add tests
Resolves rdar://104617133
This PR allows the following (similar to how the attributes works with internal/public decls):