[Macros] Disallow self and Self as macro names
#64609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were allowing `self` and `Self` as freestanding macro names, which we don’t want.
ahoppen
requested review from
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci Please smoke test |
rintaro
reviewed
Mar 24, 2023
Comment on lines
+3
to
+4
| @freestanding(expression) // expected-error {{expected expression}} | ||
| macro self() = #externalMacro(module: "MacroDefinition", type: "InvalidMacro") |
There was a problem hiding this comment.
This error message doesn't look right.
There was a problem hiding this comment.
I thought the same but I don’t think it’s worth improving it. This is silly code that I don’t expect anyone to write and if we think it’s worth improving the diagnostics for this, we should do so in the new parser.
The main motivation here is to make sure we don’t have to carry the baggage of supporting macros named self around later on.
rintaro
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were allowing
selfandSelfas freestanding macro names, which we don’t want.Change
parseDeclNameRefso that you need to explicitly request parsing ofselforSelfas the declaration’s base name, and adjust all call sites except those for macros to pass that flag.