[5.9][Macros] Disallow self and Self as macro names
#64804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were allowing `self` and `Self` as freestanding macro names, which we don’t want.
|
@swift-ci Please test |
DougGregor
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #64609 to
release/5.9.We were allowing
selfandSelfas freestanding macro names, which we don’t want. We should ban this before introducing macros as a new feature and it starts to become legacy we will carry around forever.Change
parseDeclNameRefso that you need to explicitly request parsing ofselforSelfas the declaration’s base name, and adjust all call sites except those for macros to pass that flag.