Skip to content

[Backtracing] Add an option to output to stderr. #64639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023

Conversation

al45tair
Copy link
Contributor

In CI, it would be better if the backtraces went to stderr rather than stdout, so provide an option for that.

rdar://107192120

@al45tair al45tair requested a review from a team as a code owner March 27, 2023 14:41
@al45tair
Copy link
Contributor Author

Original is at #64611

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair requested a review from mikeash March 30, 2023 10:51
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
@al45tair al45tair changed the title [Backtracing] (Cherry Pick) Add an option to output to stderr. [Backtracing] Add an option to output to stderr. May 4, 2023
In CI, it would be better if the backtraces went to stderr rather than
stdout, so provide an option for that.

rdar://107192120
@al45tair al45tair force-pushed the eng/PR-107192120-5.9 branch from 3322551 to 3b11c20 Compare May 23, 2023 10:38
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Explanation: Adds an option to control whether backtracer output goes to stdout or stderr.
Risk: Low. Only affects the backtracer, which only kicks in when things crash. Has been on main for a while now.
Original PR: #64611
Reviewed by: @ktoso, @mikeash
Resolves: rdar://107192120
Tests: The backtracer has tests that exercise this option (it's always passed through, no matter what the setting is).

@al45tair al45tair merged commit 3f4da1b into swiftlang:release/5.9 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants