Skip to content

[5.9][Tests] Enable backtracing for crashing tests. #66075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

[5.9][Tests] Enable backtracing for crashing tests. #66075

merged 1 commit into from
May 25, 2023

Conversation

al45tair
Copy link
Contributor

Enable the new Swift backtracer, which should result in backtraces appearing for tests that crash.

rdar://109707611

@al45tair
Merge pull request swiftlang#64569 from al45tair/eng/PR-107131576
821c5fc 
[Tests] Enable backtracing for crashing tests.
@al45tair al45tair requested a review from a team as a code owner May 23, 2023 10:33
@al45tair
Copy link
Contributor Author

al45tair commented May 23, 2023 •
edited
Loading

Explanation: Turns on the new Swift on-crash backtracer, for macOS builds only, for lit tests.
Risk: Low. Only affects tests, and only those that crash. We've been running with this enabled on main for a while now.
Original PR: #64569
Reviewed by: @ktoso
Resolves: rdar://109707611
Tests: There are tests that test the backtracer, but this is really about getting backtraces from things in CI.

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Hmmm. I think that might also require that we merge #64639 first.

@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 23, 2023
ktoso
ktoso approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :-) In case we get a random flaky crash it'll always be better to have a backtrace rather than not

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair merged commit 66b6e39 into swiftlang:release/5.9 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al45tair @ktoso @airspeedswift