Skip to content

[5.9] [AST] add a source location for GenericTypeParamDecls #64722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #64688

  • Explanation: Functions with a mix of generic type parameters and existential types crash SymbolGraphGen and any other users of SourceEntityWalker.
  • Scope: The change introduces a source location for GenericTypeParamDecl, which previously had none. This doesn't seem to affect any consumers of it (i checked SourceKit's cursor info, -dump-ast, and SymbolGraphGen), but the change may affect other internals of the compiler.
  • Issue: rdar://105982860
  • Risk: Low. The addition of the source location for GenericTypeParamDecl seems to be unused, and this change should not affect normal compilation.
  • Testing: An automated test has been added to ensure that SymbolGraphGen's use of SourceEntityWalker no longer trips an assertion on a reproduction. Existing automated tests still pass.
  • Reviewer: @slavapestov

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner March 29, 2023 16:13
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit 7b0d1a4 into release/5.9 Mar 31, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/opaque-param-mix branch March 31, 2023 16:32
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants