Skip to content

[5.9] [AST] add a source location for GenericTypeParamDecls #64722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[5.9] [AST] add a source location for GenericTypeParamDecls #64722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/AST/NameLookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3050,7 +3050,8 @@ createOpaqueParameterGenericParams(GenericContext *genericContext, GenericParamL
// Allocate a new generic parameter to represent this opaque type.
auto *gp = GenericTypeParamDecl::createImplicit(
dc, Identifier(), GenericTypeParamDecl::InvalidDepth, index++,
/*isParameterPack*/ false, /*isOpaqueType*/ true, repr);
/*isParameterPack*/ false, /*isOpaqueType*/ true, repr,
/*nameLoc*/ repr->getStartLoc());

// Use the underlying constraint as the constraint on the generic parameter.
// The underlying constraint is only present for OpaqueReturnTypeReprs
Expand Down
15 changes: 15 additions & 0 deletions test/SymbolGraph/Symbols/OpaqueParams.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: %empty-directory(%t)
// RUN: %target-swift-frontend -swift-version 5 %s -emit-module -emit-module-path %t/OpaqueParams.swiftmodule -emit-symbol-graph -emit-symbol-graph-dir %t/
// RUN: %{python} -m json.tool %t/OpaqueParams.symbols.json %t/OpaqueParams.formatted.symbols.json
// RUN: %FileCheck %s --input-file %t/OpaqueParams.formatted.symbols.json

// CHECK: "precise": "s:12OpaqueParams7MyClassC6myFunc5param10otherParamyq__xtAA0C8ProtocolRzAaGR_r0_lF"

public protocol MyProtocol {}

public class MyClass {
public func myFunc<S: MyProtocol>(
param: some MyProtocol,
otherParam: S
) {}
}