Skip to content

don't print macro definitions in symbol graphs #64732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Resolves rdar://106862694

This PR removes macro definitions from declaration fragments and name subheadings in SymbolGraphGen. This is done by adding a new AST Printer option, PrintMacroDefinitions, that defaults to true but is turned off in SymbolGraphGen.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuietMisdreavus QuietMisdreavus merged commit 0d74959 into main Mar 29, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/macro-def branch March 29, 2023 23:04
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

etcwilde pushed a commit to etcwilde/swift that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants