Skip to content

[5.9] don't print macro definitions in symbol graphs #64749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

[5.9] don't print macro definitions in symbol graphs #64749

merged 1 commit into from
Mar 31, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #64732

rdar://106862694

  • Explanation: The symbol-graph representation of macros includes the macro definition, which is not useful for a user of a macro.
  • Scope: Affects users of macros who are reading documentation of those macros.
  • Issue: rdar://106862694
  • Risk: Low. This is a very light modification of the AST Printer code to optionally skip printing macro definitions, which is only turned on in SymbolGraphGen.
  • Testing: A test has been added to test the new behavior. Existing automated tests pass.
  • Reviewer: @DougGregor

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner March 29, 2023 23:02
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus force-pushed the QuietMisdreavus/5.9/macro-def branch from ced1b15 to b924e90 Compare March 31, 2023 16:31
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit 8396c47 into release/5.9 Mar 31, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/macro-def branch March 31, 2023 23:18
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuietMisdreavus @tbkka @AnthonyLatsis