[Macros] Unpack DiagnosticsError into separate diagnostics #64744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://107289985.
|
@swift-ci please smoke test |
bnbarham
reviewed
Mar 29, 2023
| @@ -805,6 +813,15 @@ func expandAttachedMacroInProcess( | |||
| print("\(macroPtr) does not conform to any known attached macro protocol") | |||
| return nil | |||
| } | |||
| } catch let diagsError as DiagnosticsError { | |||
There was a problem hiding this comment.
We could just call addDiagnostics in the block below instead, which would better match things on the swift-syntax side. Alternatively we could have a non-throwing extension that does this on the swift-syntax side as well.
That would also avoid repeating the from macro bits which is ... kind of nice 🤷
There was a problem hiding this comment.
Yes, you're right, I'm doing this in #64785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://107289985.