[Macros] Unpack DiagnosticsError into separate diagnostics #64745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
airspeedswift
approved these changes
Mar 30, 2023
Fixes rdar://107289985.
Rather than open-coding the mapping of thrown errors to diagnostics, use `MacroExpansionContext.addDiagnostics`. It already does the right thing.
DougGregor
force-pushed
the
macros-unpack-diagnosticserror-5.9
branch
from
64c7c13 to
71974f1
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiagnosticsError, which can bundle together multiple diagnostics, make sure to "unpack" those into separate diagnostics. We were flattening them into one error diagnostic that lots all of the specific locations / highlights / Fix-Its of the originals.