Skip to content

[Executors] Move assert/assume APIs onto actors; assumeIsolated() #64812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 31, 2023

Via SE feedback, move all assert/precondition/assume funcs onto actor and serial executors.

Sadly global actors we cannot really abstract over still, so this remains being a special case for the @MainActor () ->

Needs a few small cleanups still

@ktoso ktoso added concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor labels Mar 31, 2023
@ktoso ktoso marked this pull request as draft March 31, 2023 08:10
@ktoso ktoso force-pushed the wip-move-assert-apis branch from 112c5cf to 0328113 Compare April 3, 2023 03:07
@ktoso ktoso requested review from jckarter and DougGregor April 3, 2023 03:13
@ktoso ktoso force-pushed the wip-move-assert-apis branch from 0328113 to 762cc38 Compare April 3, 2023 03:23
@ktoso
Copy link
Contributor Author

ktoso commented Apr 3, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 3, 2023

An autocompletion test I missed to update;

@ktoso
Copy link
Contributor Author

ktoso commented Apr 3, 2023

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 3, 2023

Discussed direction with @jckarter, merging

@ktoso ktoso merged commit b8780c9 into swiftlang:main Apr 3, 2023
@ktoso ktoso deleted the wip-move-assert-apis branch April 3, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant