[SourceKit] Pass 'swiftc' path to Driver when creating frontend args #65068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
sourcekit-pluginpath-rdar107849796
branch
2 times, most recently
from
5d8c849 to
84778ee
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
sourcekit-pluginpath-rdar107849796
branch
from
84778ee to
7797d96
Compare
|
@swift-ci Please test |
rintaro
force-pushed
the
sourcekit-pluginpath-rdar107849796
branch
from
7797d96 to
bbe1ae3
Compare
|
@swift-ci Please test |
rintaro
changed the title
|
@swift-ci Please test |
rintaro
commented
Apr 11, 2023
| llvm::outs() << "Frontend Arguments END\n"; | ||
| return CI.parseArgs(FrontendArgs, Diags); | ||
| }, ForceNoOutputs); | ||
| MainExecutablePath, Args, Diags, |
There was a problem hiding this comment.
MainExecutablePath is a path to swift-ide-test So it's not really correct. But it is enough for getSingleFrontendInvocationFromDriverArguments
rintaro
force-pushed
the
sourcekit-pluginpath-rdar107849796
branch
from
bbe1ae3 to
e42ce7d
Compare
|
@swift-ci Please test |
|
swiftlang/llvm-project#6633 |
Driver uses its path to derive the plugin paths (i.e. 'lib/swift/host/plugins' et al.) Previously it was a constant string 'swiftc' that caused SourceKit failed to find dylib plugins in the toolchain. Since 'SwiftLangSupport' knows the swift-frontend path, use it, but replacing the filename with 'swiftc', to derive the plugin paths. rdar://107849796
rintaro
force-pushed
the
sourcekit-pluginpath-rdar107849796
branch
from
e42ce7d to
3517db4
Compare
|
@swift-ci Please test |
ahoppen
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver uses its path to derive the plugin paths (i.e. 'lib/swift/host/plugins' et al.) Previously it was a constant string 'swiftc' that caused SourceKit failed to find dylib plugins in the toolchain. Since 'SwiftLangSupport' knows the swift-frontend path, use it, but replacing the filename with 'swiftc', to derive the plugin paths.
rdar://107849796