[DNM][Serialization] Preserve indirect conformances knowledge with safety #65084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci Please smoke test macOS |
When getTopLevelDeclsForDisplay is called on an imported module, it may lists non-public decls. If we they try to inject the conformance on Sendable on internal types, the compiler may crash on failing to deserialize internal details. As a fix, let's only inject the conformance on public or package types. rdar://95430471
Disabling access control is fundamentally incompatible with deserialization safety. Let's turn off safety automatically when in use. This was reported by a few tests: stdlib/Dictionary.swift stdlib/Set.swift stdlib/SetOperations.swift.gyb stdlib/SwiftNativeNSBase.swift
rdar://105241772
xymus
force-pushed
the
serial-indirect-conformances
branch
from
ef8630d to
9fe07a4
Compare
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci Please test |
|
The compatibility suite doesn't show any new regression. Closing in favor of a feature PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.