[Serialization] Keep indirect conformances knowledge with safety #65267
+66
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a scenario where a public type A, conforms to an internal protocol B, which conforms to a public protocol C. A conforms indirectly to C through a protocol that's hidden from the clients. This is handled in module interface by printing the indirect conformance of A to C explicitly at the end of the swiftinterface. We have the same problem with deserialization safety that used to hide the internal protocols from clients, thus breaking the knowledge of the indirect dependency. To keep the indirect conformances, let's consider all protocols as safe and preserve their conformance information. rdar://105241772
|
@swift-ci Please smoke test |
|
Testing against the source compatibility suite with deserialization safety enabled showed no regressions from this change: #65084 |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 30, 2023
In swiftlang#65267 deserialization safety was made more conservative, allowing deserialization of any protocol and deserialization of any extension declaring an explicit conformance to any protocol. We can refine this to only allow deserialization of safe protocols and deserialization of extensions declaring conformances to safe protocols. Importantly, though, we must look up all conformances declared by the extension, not just the explicit ones. Resolves rdar://114673761
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 30, 2023
In swiftlang#65267 deserialization safety was made more conservative, allowing deserialization of any protocol and deserialization of any extension declaring an explicit conformance to any protocol. We can refine this to only allow deserialization of safe protocols and deserialization of extensions declaring conformances to safe protocols. Importantly, though, we must look up all conformances declared by the extension, not just the explicit ones. Resolves rdar://114673761
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 30, 2023
In swiftlang#65267 deserialization safety was made more conservative, allowing deserialization of any protocol and deserialization of any extension declaring an explicit conformance to any protocol. We can refine this to only allow deserialization of safe protocols and deserialization of extensions declaring conformances to safe protocols. Importantly, though, we must look up all conformances declared by the extension, not just the explicit ones. Resolves rdar://114673761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a scenario where a public type
A, conforms to an internal protocolB, which conforms to a public protocolC.Aconforms indirectly toCthrough a protocol that's hidden from the clients.This is handled in module interface by printing the indirect conformance of
AtoCexplicitly at the end of the swiftinterface.We have the same problem with deserialization safety that used to hide the internal protocols from clients, thus breaking the knowledge of the indirect dependency. To keep the indirect conformances, let's consider all protocols as safe and preserve extensions declaring conformances.
rdar://105241772