Skip to content

Re-enable discarding group tests #65242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 18, 2023

Reenable those tests

Because of the fix #65220

rdar://104762037

@ktoso
Copy link
Contributor Author

ktoso commented Apr 18, 2023

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Apr 19, 2023

@swift-ci please test windows

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Apr 19, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Apr 19, 2023

These do fail on windows :-\

   Creating library T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_discarding_neverConsumingTasks.swift.tmp\a.lib and object T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_discarding_neverConsumingTasks.swift.tmp\a.exp


$ "echo" "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_discarding_neverConsumingTasks.swift.tmp/a.out"
# command output:
T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_discarding_neverConsumingTasks.swift.tmp/a.out

$ "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_discarding_neverConsumingTasks.swift.tmp/a.out"
note: command had no output on stdout or stderr
error: command failed with exit status: 3221225477
$ "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe" "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\utils\PathSanitizingFileCheck" "--allow-unused-prefixes" "--sanitize" "BUILD_DIR=T:/1/tools/swift" "--sanitize" "SOURCE_DIR=C:/Users/swift-ci/jenkins/workspace/swift-PR-windows/swift" "--use-filecheck" "t:\1\bin\filecheck.exe" "--enable-windows-compatibility" "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_discarding_neverConsumingTasks.swift" "--dump-input=always"
# command stderr:
FileCheck error: '<stdin>' is empty.
FileCheck command line:  t:\1\bin\filecheck.exe --allow-unused-prefixes C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_discarding_neverConsumingTasks.swift --dump-input=always

error: command failed with exit status: 2

--

********************
Testing:  0.
FAIL: Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_rethrow.swift (599 of 9276)
******************** TEST 'Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_rethrow.swift' FAILED ********************
Script:
--
: 'RUN: at line 1';   rm -rf "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp" && mkdir -p "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp" && 't:\\1\\bin\\swiftc.exe' -target x86_64-unknown-windows-msvc  -vfsoverlay T:/1/tools/swift\stdlib\windows-vfs-overlay.yaml -swift-version 4  -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -Xfrontend -define-availability -Xfrontend 'SwiftStdlib 5.9:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999'  -libc MD -module-cache-path T:\1\swift-test-results\x86_64-unknown-windows-msvc\clang-module-cache C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_throw_rethrow.swift  -Xfrontend -disable-availability-checking -parse-as-library -o T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out -module-name main  && echo T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out &&  T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out | "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe" C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\utils\PathSanitizingFileCheck --allow-unused-prefixes --sanitize BUILD_DIR=T:/1/tools/swift --sanitize SOURCE_DIR=C:/Users/swift-ci/jenkins/workspace/swift-PR-windows/swift --use-filecheck t:\1\bin\filecheck.exe --enable-windows-compatibility C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_throw_rethrow.swift --dump-input=always
--
Exit Code: 2

Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "rm" "-rf" "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp"
$ "mkdir" "-p" "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp"
$ "t:\\1\\bin\\swiftc.exe" "-target" "x86_64-unknown-windows-msvc" "-vfsoverlay" "T:/1/tools/swift\stdlib\windows-vfs-overlay.yaml" "-swift-version" "4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4" "-Xfrontend" "-define-availability" "-Xfrontend" "SwiftStdlib 5.9:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999" "-libc" "MD" "-module-cache-path" "T:\1\swift-test-results\x86_64-unknown-windows-msvc\clang-module-cache" "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_throw_rethrow.swift" "-Xfrontend" "-disable-availability-checking" "-parse-as-library" "-o" "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out" "-module-name" "main"
# command stderr:
   Creating library T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp\a.lib and object T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp\a.exp


$ "echo" "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out"
# command output:
T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out

$ "T:\1\tools\swift\test-windows-x86_64\Concurrency\Runtime\Output\async_taskgroup_throw_rethrow.swift.tmp/a.out"
note: command had no output on stdout or stderr
error: command failed with exit status: 3221225477
$ "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe" "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\utils\PathSanitizingFileCheck" "--allow-unused-prefixes" "--sanitize" "BUILD_DIR=T:/1/tools/swift" "--sanitize" "SOURCE_DIR=C:/Users/swift-ci/jenkins/workspace/swift-PR-windows/swift" "--use-filecheck" "t:\1\bin\filecheck.exe" "--enable-windows-compatibility" "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_throw_rethrow.swift" "--dump-input=always"
# command stderr:
FileCheck error: '<stdin>' is empty.
FileCheck command line:  t:\1\bin\filecheck.exe --allow-unused-prefixes C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\test\Concurrency\Runtime\async_taskgroup_throw_rethrow.swift --dump-input=always

error: command failed with exit status: 2

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 

4 warning(s) in tests
********************
Failed Tests (3):
  Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding.swift
  Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding_neverConsumingTasks.swift
  Swift(windows-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_rethrow.swift

@ktoso
Copy link
Contributor Author

ktoso commented Apr 19, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 9dff5f2 into swiftlang:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants