[Dependency Scanning] Build libSwiftScan with Swift Modules required for parsing regex #65372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
nkcsgexi
approved these changes
Apr 21, 2023
artemcm
force-pushed
the
DepScanNowWithRegex
branch
from
6b0933e to
83be391
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test Windows platform |
|
@swift-ci smoke test |
…for parsing regex Otherwise scanning actions which encounter regex literals will fail. Resolves rdar://108321860
artemcm
force-pushed
the
DepScanNowWithRegex
branch
from
83be391 to
6c71d80
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS platform |
|
@artemcm, since you added this, I see an incorrect runpath added to this library on linux: The issue is that you've triggered this CMake function to automatically add the Swift runpath, which fails because it expects all host libraries to be placed in You'll want to fix this, else this library won't always work on linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise scanning actions which encounter regex literals will fail.
Resolves rdar://108321860