Skip to content

[5.9 🍒][Dependency Scanning] Build libSwiftScan with Swift Modules required for parsing regex #65373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 21, 2023

Cherry-pick of #65372

Otherwise scanning actions which encounter regex literals will fail.

Resolve rdar://108321860

@artemcm artemcm requested review from nkcsgexi and eeckstein April 21, 2023 22:38
@artemcm artemcm requested a review from a team as a code owner April 21, 2023 22:38
@artemcm
Copy link
Contributor Author

artemcm commented Apr 21, 2023

This affects how the dependency scanner library is built and configured only. No impact on implicit module builds.

@artemcm
Copy link
Contributor Author

artemcm commented Apr 21, 2023

@swift-ci test

@nkcsgexi
Copy link
Contributor

@edymtt mind taking a look at this?

@artemcm artemcm force-pushed the 59DepScanNowWithRegex branch from c3a421e to 7cf59d4 Compare April 24, 2023 21:54
@artemcm
Copy link
Contributor Author

artemcm commented Apr 24, 2023

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Apr 24, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 25, 2023

@swift-ci test

…for parsing regex

Otherwise scanning actions which encounter regex literals will fail.

Resolves rdar://108321860
@artemcm artemcm force-pushed the 59DepScanNowWithRegex branch from 7cf59d4 to 7faadf4 Compare April 25, 2023 17:18
@artemcm
Copy link
Contributor Author

artemcm commented Apr 25, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 25, 2023

@swift-ci test macOS platform

@artemcm artemcm merged commit 8f3e3d5 into swiftlang:release/5.9 Apr 26, 2023
@artemcm artemcm deleted the 59DepScanNowWithRegex branch April 26, 2023 15:23
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants