[Macros] Allow the back-ticked named(init) to be treated like named(init).
#65442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…med(init)`. My recent change to parse initializer names in the macro role introduced names now correctly distinguishes between the two forms, but this breaks any existing macros written with the back-ticked form. Treat the former as the latter to provide a grace period for such macros. Fixes rdar://108571834.
|
@swift-ci please smoke test |
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Jun 23, 2023
…utes. The excessive escaping of `init` in macro role attributes was a workaround paired with swiftlang#65442 to smooth things over when working across Swift compiler versions. However, it's causing problems for init accessors, so stop escaping. Fixes rdar://111190084.
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Jun 23, 2023
…utes. The excessive escaping of `init` in macro role attributes was a workaround paired with swiftlang#65442 to smooth things over when working across Swift compiler versions. However, it's causing problems for init accessors, so stop escaping. Fixes rdar://111190084.
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Jun 23, 2023
…utes. The excessive escaping of `init` in macro role attributes was a workaround paired with swiftlang#65442 to smooth things over when working across Swift compiler versions. However, it's causing problems for init accessors, so stop escaping. Fixes rdar://111190084.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change to parse initializer names in the macro role introduced names now correctly distinguishes between the two forms, but this breaks any existing macros written with the back-ticked form. Treat the former as the latter to provide a grace period for such macros.
Fixes rdar://108571834.