Skip to content

[Macros] Allow the back-ticked named(init) to be treated like named(init). #65443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

  • Explanation: My recent change to parse initializer names in the macro role introduced names now correctly distinguishes between the two forms, but this breaks any existing macros written with the back-ticked form. Treat the former as the latter to provide a grace period for such macros.
  • Scope: Narrow; only affects macros that define an introduced name of the form named(init).
  • Risk: Low, narrowly applied to macros.
  • Issue: rdar://108571834
  • Original pull request: [Macros] Allow the back-ticked named(init) to be treated like named(init). #65442

…med(init)`.

My recent change to parse initializer names in the macro role
introduced names now correctly distinguishes between the two forms, but
this breaks any existing macros written with the back-ticked form.
Treat the former as the latter to provide a grace period for such
macros.

Fixes rdar://108571834.
@DougGregor DougGregor requested a review from a team as a code owner April 26, 2023 20:27
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 6ae727a into swiftlang:release/5.9 Apr 27, 2023
@DougGregor DougGregor deleted the macro-name-back-ticked-init-as-init-5.9 branch April 27, 2023 01:36
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants