🍒[5.9][Executors] Make move to ExecutorJob binary compatible; deprecate Job #65459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ktoso
changed the title
DougGregor
approved these changes
Apr 27, 2023
|
rdar://108772378 |
AnthonyLatsis
added
🍒 release cherry pick
|
@swift-ci please test |
This comment was marked as resolved.
This comment was marked as resolved.
Closed
|
Maybe it's just in one of the configurations we test here hmmm |
kavon
reviewed
May 5, 2023
ktoso
force-pushed
the
pick-wip-bincompat-job-rename
branch
from
3d46a69 to
436325b
Compare
|
@swift-ci please test Linux |
ktoso
force-pushed
the
pick-wip-bincompat-job-rename
branch
from
436325b to
4fc21de
Compare
|
@swift-ci please test and merge The avoiding of Self is what will cause the weird test failure here -- there was misalignment on using Job and ExecutorJob in the test due to other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In #65038 we renamed Job to ExecutorJob and introduced a typealias. We knew this would be binary breaking however we hoped the change would not cause problems since noone had adopted this new API yet -- we were wrong.
This change introduces a binary compatible way to introduce ExecutorJob while keeping Job as deprecated and hopefully we'd be able to remove it still.
Diagnostics were adjusted to handle the new type and push developers towards the right implementation method.
Risk: Medium, this de-risks the binary compat break; The logic in diagnosing methods had to be carefully adjusted.
Review by: @DougGregor @airspeedswift @hborla
Testing: CI Testing, tests covering all three co-existing enqueue methods are added
Original PR: #65455
Radar: rdar://108772378