Skip to content

[Executors] Make move to ExecutorJob binary compatible; deprecate Job #65455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 27, 2023

In #65038 we renamed Job to ExecutorJob and introduced a typealias. We knew this would be binary breaking however we hoped the change would not cause problems since noone had adopted this new API yet -- we were wrong.

This change introduces a binary compatible way to introduce ExecutorJob while keeping Job as deprecated and hopefully we'd be able to remove it still.

Diagnostics were adjusted to handle the new type and push developers towards the right implementation method.

@ktoso ktoso force-pushed the wip-bincompat-job-rename branch from 59f3f16 to 95a93a9 Compare April 27, 2023 01:15
@ktoso
Copy link
Contributor Author

ktoso commented Apr 27, 2023

@swift-ci please smoke test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please format your changes with clang-format before merging.

@ktoso
Copy link
Contributor Author

ktoso commented May 2, 2023

rdar://108772378

@ktoso ktoso force-pushed the wip-bincompat-job-rename branch from 9acc587 to b847ee1 Compare May 3, 2023 02:03
@ktoso
Copy link
Contributor Author

ktoso commented May 3, 2023

@swift-ci please smoke test

@ktoso ktoso merged commit 0bdb39f into swiftlang:main May 3, 2023
@ktoso ktoso deleted the wip-bincompat-job-rename branch May 3, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants