[Concurrency] Adopt stable keyword consuming instead of __owned #65571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested changes
May 2, 2023
ktoso
force-pushed
the
wip-consuming-keyword-job
branch
2 times, most recently
from
b068a4c to
5455f33
Compare
|
@swift-ci please smoke test |
kavon
reviewed
May 2, 2023
test/Concurrency/Runtime/custom_executors_sdk_with_consuming_param_but_impl_owned.swift
Outdated
Show resolved
Hide resolved
test/Inputs/clang-importer-sdk/swift-modules-concurrency-consuming-job-param/_Concurrency.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please smoke test |
|
Depends on #65455 since that introduces new methods; so we want to do the same to the new ones IF we are to merge these new methods. |
|
@swift-ci please smoke test macOS |
ktoso
force-pushed
the
wip-consuming-keyword-job
branch
3 times, most recently
from
29cffc7 to
51db03f
Compare
add test for warnings emitted when missing consuming attribute use -emit-sil in mock SDK tests for better coverage
ktoso
force-pushed
the
wip-consuming-keyword-job
branch
from
51db03f to
da6f08a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
kavon
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is ABI stable with regards to the mangled name of the enqueue method.
We confirmed this by manually comparing mangled names of a method with
__ownedand later aconsumingparameter -- please double check this though @kavon as you'd know more about this than myself.This also improves diagnostics around implementing move-only job requirement, since the diagnostics offered by
__ownedare wrong: they don't show the attribute leading people to addfunc enqueue(_ job: ExecutorJob)which is incorrect because they MUST add consuming.This PR includes tests that simulate an SDK with either the __owned or consuming versions and implementations with the other spelling, to make sure this works as expected.
Please review @kavon
Resolves rdar://108467550