Skip to content

[Compile Time Constant Extraction] Extract the instance type for typevalues - not the metatype #65464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 27, 2023

The intended design is to extract actual types of type values appearing in conformance properties, whereas the original extraction code-path queried and recorded the type values' types - their metatypes.

@artemcm artemcm requested a review from jPaolantonio April 27, 2023 14:52
@artemcm
Copy link
Contributor Author

artemcm commented Apr 27, 2023

@swift-ci smoke test

… values - not the metatype

The intended design is to extract actual types of type values appearing in conformance properties, whereas the original extraction code-path queried and recorded the type values' types - their metatypes.

Resolves rdar://108609420
@artemcm artemcm force-pushed the ConstExtractTypeValue-not-metatype branch from b9d8f80 to 79073ed Compare April 27, 2023 15:12
@artemcm
Copy link
Contributor Author

artemcm commented Apr 27, 2023

@swift-ci smoke test

@artemcm artemcm merged commit aff5b20 into swiftlang:main Apr 27, 2023
@artemcm artemcm deleted the ConstExtractTypeValue-not-metatype branch April 27, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants