[5.9 🍒][Compile Time Constant Extraction] Extract the instance type for type values - not the metatype #65465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values - not the metatype The intended design is to extract actual types of type values appearing in conformance properties, whereas the original extraction code-path queried and recorded the type values' types - their metatypes. Resolves rdar://108609420
|
@swift-ci test |
nkcsgexi
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65464
• Release: Swift 5.9
• Explanation: The intended design is to extract actual types of type values appearing in conformance properties, whereas the original extraction code-path queried and recorded the type values' types - their metatypes.
• Scope of Issue: Compile-time extraction code produces meta type information instead of type information, encoding extraneous
.Typetype names andm-postfix mangled names• Origination: Original implementation incorrectly queried the type value type instead of instance type.
• Automated Testing: Test suite tests updated to reflect the new, and desired, behavior.
• Risk: Minimal, small change to const-extraction code path to look through to the instance type of a
.selfexpression when one is used to default-initialize a property on a conformance to the queried protocols.Resolves rdar://108609420