[Completion] Add convertible type relation for attached macros #65515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
reviewed
Apr 28, 2023
| // NOMINAL_ATTR-DAG: Decl[Macro]/{{.*}}: AttachedPeerMacro[#Void#]; name=AttachedPeerMacro | ||
| // NOMINAL_ATTR-DAG: Decl[Macro]/{{.*}}: AttachedConformanceMacro[#Void#]; name=AttachedConformanceMacro | ||
| // NOMINAL_ATTR-DAG: Decl[Macro]/{{.*}}: EverythingMacro[#Void#]; name=EverythingMacro | ||
| // NOMINAL_ATTR-DAG: Decl[Macro]/{{.*}}/TypeRelation[Convertible]: AttachedMemberMacro[#Void#]; name=AttachedMemberMacro |
There was a problem hiding this comment.
IMO that’s why we shouldn’t wildcard match anything after Decl[Macro] but always be explicit about relations etc. You don’t need to change it in this PR though.
There was a problem hiding this comment.
The issue here is that module is before type relation and this test does both in-module and cross-module completions. IMO we should move type relation before the location of the completion. I could of course regex match the current module/other module but... it's really not all that important to this test.
Resolves rdar://108678938.
bnbarham
force-pushed
the
add-attached-type-relation
branch
from
8d09160 to
f7d1cc8
Compare
ahoppen
approved these changes
Apr 28, 2023
|
@swift-ci please test |
rintaro
approved these changes
Apr 28, 2023
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://108678938.