Skip to content

[5.9][Completion] Add convertible type relation for attached macros #65520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bnbarham
Copy link
Contributor

  • Explanation: Prior to this change, there's no way to differentiate an attached macro from a type in @<here> position. This adds a convertible type relation to attached macros in this case, so that they can be ranked higher than regular types (which are only provided since they could contain eg. property wrappers).
  • Scope: Code completion
  • Risk: Very low; only impacts completion and only adds a type relation where there was none previously.
  • Testing: Updated macro completion tests to check for the type relation
  • Original PR: [Completion] Add convertible type relation for attached macros #65515

Resolves rdar://108678938.

(cherry picked from commit f7d1cc8)
@bnbarham bnbarham requested a review from DougGregor April 28, 2023 23:40
@bnbarham bnbarham requested a review from a team as a code owner April 28, 2023 23:40
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit ff060f7 into swiftlang:release/5.9 Apr 29, 2023
@bnbarham bnbarham deleted the cherry-add-attached-type-relation branch April 29, 2023 04:21
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants