[5.9][CSDiagnostics] Teach diagnoseConflictingGenericArguments about holes
#65522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fully resolved substitutions are eligible to be considered as conflicting, if holes are involved in any position that automatically disqualifies a generic parameter. Resolves: rdar://108534555 Resolves: swiftlang#63450 (cherry picked from commit 0b7aeed)
|
@swift-ci please test |
hborla
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65479
Only fully resolved substitutions are eligible to be considered as conflicting, if holes are involved in any position that automatically disqualifies a generic parameter. Any conflicting argument diagnostics with holes hide actual issues.
Scope: result builders or any other complex generic code that could have un-inferred or partially inferred generic parameters at multiple locations.
Main Branch PR: [CSDiagnostics] Teach
diagnoseConflictingGenericArgumentsabout holes #65479Resolves: rdar://108534555
Risk: Low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://108534555
Resolves: #63450
(cherry picked from commit 0b7aeed)