Fix SILGen ManagedValue::isPlusOne for addresses #65579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-memory values cannot be reused after deinitialization. Add ManagedValue::isPlusOneOrTrivial() for situations where we want to forward a value without destroying the original memory. Fixes rdar://108001491 (SIL verification failed: Found mutating or consuming use of an in_guaranteed parameter?!: !ImmutableAddressUseVerifier().isMutatingOrConsuming(fArg))
Whenever we want to forward to a +1 value but don't need to destroy the original memory, use isPlusOneOrTrivial. This follows the existing naming scheme. Fixes rdar://108001491 (SIL verification failed: Found mutating or consuming use of an in_guaranteed parameter?!: !ImmutableAddressUseVerifier().isMutatingOrConsuming(fArg))
Tests rdar://108001491 (SIL verification failed: Found mutating or consuming use of in_guaranteed parameter?!: !ImmutableAddressUseVerifier().isMutatingOrConsuming(fArg))
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci benchmark |
|
Appeared to have a connection failure when running Swift driver tests after all regular tests passed. |
|
@swift-ci test macOS Platform |
jckarter
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ManagedValue::isPlusOne for addresses