Concurrency: Make _Concurrency module interface parseable by older compilers #65599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pilers. Revert a few unnecessary changes have been made to the _Concurrency module recently that make its swiftinterface un-parseable by older compilers that we need to support. - The `consume` keyword is not understood by older compilers, so including it in inlinable code is a problem. It has no actual effect on lifetimes where it was used, so just omit it. - Don't build the _Concurrency module with -enable-experimental-feature MoveOnly. The MoveOnly feature is now enabled by default in recent compilers, so the flag is superfluous when building the dylib. When emitting the interface, having the feature enabled explicitly exposes code guarded by `$MoveOnly` to older compilers that do not accept all of the code. Resolves rdar://108793606
|
@swift-ci please test |
|
Thanks! For clarity,
This just happens to be true because lexical lifetimes aren't enabled in this module, so luckily we're able to omit the keyword to avoid the condfail. It does correctly communicate the intended behavior and should be restored when the oldest compilers we need to support are able to understand it. |
nate-chandler
approved these changes
May 2, 2023
tshortli
changed the title
kavon
approved these changes
May 3, 2023
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 15, 2023
…n:). It is no longer necessary to avoid using the `consume` keyword in inlinable function bodies in the standard library in order to support older compilers. Partially reverts swiftlang#65599. Resolves rdar://109165937.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a few unnecessary changes have been made to the _Concurrency module recently that make its swiftinterface un-parseable by older compilers that we need to support.
consumekeyword is not understood by older compilers, so including it in inlinable code is a problem. It has no actual effect on lifetimes where it was used, so just omit it.-enable-experimental-feature MoveOnly. The MoveOnly feature is now enabled by default in recent compilers, so the flag is superfluous when building the dylib. When emitting the interface, having the feature enabled explicitly exposes code guarded by$MoveOnlyto older compilers that do not accept all of the code.Resolves rdar://108793606