Skip to content

Concurrency: Restore consume in TaskLocal.withValueImpl<R>(_:operation:) #67932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

Concurrency: Restore consume in TaskLocal.withValueImpl<R>(_:operation:) #67932

merged 1 commit into from
Aug 15, 2023

Conversation

tshortli
Copy link
Contributor

It is no longer necessary to avoid using the consume keyword in inlinable function bodies in the standard library in order to support older compilers.

Partially reverts #65599.

Resolves rdar://109165937.

@tshortli
Concurrency: Restore consume in TaskLocal.withValueImpl<R>(_:operatio…
5cc7fff 
…n:).

It is no longer necessary to avoid using the `consume` keyword in inlinable
function bodies in the standard library in order to support older compilers.

Partially reverts swiftlang#65599.

Resolves rdar://109165937.
@tshortli tshortli requested a review from nate-chandler August 15, 2023 05:23
@tshortli tshortli requested review from ktoso and kavon as code owners August 15, 2023 05:23
@tshortli
Copy link
Contributor Author

@swift-ci please test

ktoso
ktoso approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, afaik this restores the keyword that was here but was temporarily removed. Thanks for bringing it back -- it conveys the right semantics here

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Aug 15, 2023
nate-chandler
nate-chandler approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tshortli tshortli merged commit 113bfc7 into swiftlang:main Aug 15, 2023
@tshortli tshortli deleted the restore-task-local-with-value-impl-consume branch August 15, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@nate-chandler nate-chandler nate-chandler approved these changes

@kavon kavon Awaiting requested review from kavon

Assignees
No one assigned
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshortli @ktoso @nate-chandler