Skip to content

[5.9][CodeCompletion] Only show type annotations for macros that return non-void #65717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 5, 2023

  • Explanation: Showing the type annotation only makes sense if they are not Void. That’s consistent with functions where we also don’t show a Void return type. Most importantly, we shouldn’t be showing a Void type annotation for attached macros.
  • Scope: Code completion
  • Risk: Minimal
  • Testing: Updated existing test case to expected behavior
  • Issue: rdar://108870970
  • Reviewer: @bnbarham on [CodeCompletion] Only show type annotations for macros that return non-void #65637

…n-void

Showing the type annotation only makes sense if they are not `Void`. That’s consistent with functions where we also don’t show a `Void` return type. Most importantly, we shouldn’t be showing a `Void` type annotation for attached macros.

rdar://108870970
@ahoppen ahoppen requested a review from a team as a code owner May 5, 2023 20:43
@ahoppen ahoppen changed the title [CodeCompletion] Only show type annotations for macros that return non-void [5.9][CodeCompletion] Only show type annotations for macros that return non-void May 5, 2023
@ahoppen ahoppen added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 5, 2023
@ahoppen
Copy link
Member Author

ahoppen commented May 5, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit cd83ac2 into swiftlang:release/5.9 May 12, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/macro-type-annotation branch May 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants