allow discard in generic noncopyable type
#65896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was preventing you from writing `discard self` in a consuming method of a generic noncopyable type. The main cause was the `isPureMoveOnly` ignored unbound generic types, claiming none of them are noncopyable. Then I also needed to pass the contextual type with the vars bound to the type checker. rdar://108975216
|
@swift-ci please smoke test and merge |
slavapestov
reviewed
May 13, 2023
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was preventing you from writing
discard selfin a consuming method of a generic noncopyable type.The main cause was the
isPureMoveOnlyignoredunbound generic types, claiming none of them are
noncopyable. Then I also needed to pass the contextual type with the vars bound to the type checker.
rdar://108975216