[5.9🍒] Batch of small noncopyable type fixes #65912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was preventing you from writing `discard self` in a consuming method of a generic noncopyable type. The main cause was the `isPureMoveOnly` ignored unbound generic types, claiming none of them are noncopyable. Then I also needed to pass the contextual type with the vars bound to the type checker. rdar://108975216 (cherry picked from commit 20b060b)
Subscripts today don't support any form of ownership specifier for its parameters Since noncopyable types require such a specifier, it's not helpful to emit an error suggesting to add the specifier. rdar://109233314 (cherry picked from commit 3ce8244)
Don't use `getDeclaredTypeInContext` it gives the wrong types for generic params. rdar://108975216 (cherry picked from commit da9847a)
previous checking for the expr being `self` was checking for the decl being named `self`. that meant you could do naughty things like: ``` let `self` = Self() discard `self` ``` rdar://109376381 (cherry picked from commit 1c9ed33)
|
@swift-ci please test |
jckarter
approved these changes
May 16, 2023
tbkka
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick of
discardin generic noncopyable type #65896discardfixes in Sema #65931• Description: Fixes small Sema bug preventing
discardstatements in generic noncopyable types.• Risk: Low. Expands the kinds of code permitted by compiler.
• Original PR: #65896 and one commit of #65931
• Reviewed By: @slavapestov, @jckarter
• Testing: tests included
• Resolves: rdar://108975216
• Description: Subscripts today don't support any form of ownership specifier for its parameters. Since noncopyable types require such a specifier, it's not helpful to emit an error suggesting to add the specifier. Instead, just say that noncopyable types can't be parameters of a subscript.
• Risk: Low. replaces one error diagnostic with a different one that has no fix-it.
• Original PR: #65898
• Reviewed By: @jckarter
• Testing: tests included
• Resolves: rdar://109233314
• Description: Prevent
discard `self`from being permitted• Risk: Low. I doubt anybody was skirting around the discard self restriction with
let `self` = x• Original PR: one commit of #65931
• Reviewed By: @jckarter
• Testing: tests included
• Resolves: rdar://109376381