[5.9][Sema] Improvements to variadic generics inference and diagnostics #65950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…ix-it
Diagnose situations where value pack is referenced without an explicit 'each':
```swift
func compute<each T>(_: repeat each T) {}
func test<each T>(v: repeat each T) {
repeat compute(v) // should be `repeat compute(each v)`
}
```
(cherry picked from commit 31e0a52)
(cherry picked from commit 5836490)
(cherry picked from commit eee7e18)
(cherry picked from commit e3d1317)
…ashable conversion Failure of an argument to AnyHashable parameter to conform to Hashable protocol should be detected in `simplifyConformsToConstraint` and fixed there. Doing so requires impact assessment adjustment because regular conformance requirements have default impact of 1, this is going to have argument impact of 2 not avoid clashing with other failures. Resolves: rdar://108977234 (cherry picked from commit 5f8e3eb) (cherry picked from commit 58ffca8) (cherry picked from commit 440bc39) (cherry picked from commit 4a2d139) (cherry picked from commit c9c6311)
…d `Any` Don't attempt to wrap `Any` into a single-element tuple to match against a tuple with pack expansions, this conversion would be handled by existential promotion if it's allowed, otherwise it would produce an error. Resolves: rdar://109160060 (cherry picked from commit 181d2d1)
(cherry picked from commit bb0cce7)
xedin
force-pushed
the
more-variadic-sema-improvements-5.9
branch
from
f671c9d to
2eff1cd
Compare
|
@swift-ci please test |
hborla
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
A collection of fixed to variadic generics inference and diagnostics:
AnyVoidfor closure resultAnyHashableconversionScope: Expressions with value pack expansions
Main Branch PRs: [CSSimplify] Allow conversions between tuples with pack expansions and
Any#65861, [CSSimplify] Allow converting pack expansion types and tuples with pack expansions to Void for closure result #65830, [CSSimplify] Detect and diagnose conformance failures related to AnyHashable conversion #65806, [ConstraintSystem] Detect and diagnose missing 'each' and provide a fix-it #65718Resolves: rdar://109160060, rdar://108904190, rdar://108977234, rdar://106737972
Risk: Low
Reviewed By: @hborla
Testing: Added regression test-cases to the suite.