Skip to content

Fix LowerAggregateInstrs to avoid lowering move-only types #66142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

atrick
Copy link
Contributor

@atrick atrick commented May 25, 2023

Fixes rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)

Fixes rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)
@atrick atrick force-pushed the fix-loweragregate branch from 95f551e to 8c3b8b2 Compare May 25, 2023 20:22
@atrick
Copy link
Contributor Author

atrick commented May 25, 2023

@swift-ci test

@gottesmm
Copy link
Contributor

@swift-ci smoke test

@atrick
Copy link
Contributor Author

atrick commented May 25, 2023

@gottesmm This PR is exposing a couple of other problems:

The timeout is a concern. My machine was crashing each time I tested locally and I initially thought that was unrelated...

Distributed/distributed_actor_ban_owned_shared.swift' FAILED

swift/test/Distributed/distributed_actor_ban_owned_shared.swift:18:25: error: incorrect message found
  // expected-error@-1{{Copyable types cannot be 'consuming' or 'borrowing' yet}}
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                        copyable types cannot be 'consuming' or 'borrowing' yet
Interpreter/moveonly_escaping_capture_lifetimes.swift' FAILED
- Timeout

@atrick
Copy link
Contributor Author

atrick commented Jun 6, 2023

Fixed in #66314

@atrick atrick closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants