[5.9] Fix LowerAggregateInstrs to avoid lowering move-only types #66144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
changed the title
tbkka
approved these changes
May 25, 2023
Fixes rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)
atrick
force-pushed
the
5.9-fix-loweraggregates
branch
from
49fc4b1 to
c823f9e
Compare
|
@swift-ci test |
|
Now in PR: #66357! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)
(cherry picked from commit 95f551e)
Explanation: LowerAggregateInstrs converts aggregate destroys and releases into memberwise destroys and releases. Doing so deletes struct deinitializers.
Scope of Issue: A struct's deinit would silently fail to run when the struct was a member within another type. In the most trivial cases, with no type composition, and earlier MoveOnlyDeinitInsertion pass was hiding the problem.
Risk: Zero risk to regular copyable code. And non-copyable was already broken.
PR to main: Fix LowerAggregateInstrs to avoid lowering move-only types #66142
Reviewed By: Michael Gottesman
Resolves: rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)