[5.9] IRGen: Assorted -unavailable-decl-optimization fixes
#66225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
added
🍒 release cherry pick
When `-unavailable-decl-optimization=complete` is specified, exclude unavailable enum cases from the runtime layout of enums with payloads. Without this, the type metadata for unavailable types may be referenced by enum cases with unavailable payloads and cause linker failures. Resolves rdar://107483852
When `-unavailable-decl-optimization=complete` is specified, skip emission of resilient tag indices for enum cases that are marked unavailable with `@available`. Resolves rdar://109805050
Resolves rdar://109911571
…ilability(). Unfortunately, I don't have reduced reproduction for the crash that motivated this fix, but similar precautions are taken elsewhere when handling PatternBindingDecls.
tshortli
force-pushed
the
unavailability-cherry-picks-5.9
branch
from
efcc04a to
e5d1471
Compare
|
@swift-ci please test |
tshortli
changed the title
-unavailable-decl-optimization fixes-unavailable-decl-optimization fixes
nkcsgexi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-unavailable-decl-optimization=completeflag is specified.@availableattribute when the-unavailable-decl-optimization=completeflag is specified.