Skip to content

IRGen: Avoid emitting Obj-C method metadata for unavailable methods #66232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 31, 2023

Additionally, fix a crash when querying availability for empty PatternBindingDecls.

Resolves rdar://109911571

@tshortli
Copy link
Contributor Author

@swift-ci please test

tshortli added 2 commits May 31, 2023 18:19
…ilability().

Unfortunately, I don't have reduced reproduction for the crash that motivated
this fix, but similar precautions are taken elsewhere when handling
PatternBindingDecls.
@tshortli tshortli force-pushed the unavailable-objc-override branch from 3cffa85 to 40648b7 Compare June 1, 2023 01:24
@tshortli
Copy link
Contributor Author

tshortli commented Jun 1, 2023

@swift-ci please test

@tshortli tshortli marked this pull request as ready for review June 1, 2023 01:25
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tshortli tshortli merged commit 583c8de into swiftlang:main Jun 1, 2023
@tshortli tshortli deleted the unavailable-objc-override branch June 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants