[Parse/Sema/SIL] Implementation of init accessors feature (under a flag) #66283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS |
|
swiftlang/llvm-project#6945 |
|
@swift-ci please build toolchain macOS |
|
@swift-ci please build toolchain macOS |
xedin
force-pushed
the
init-accessors
branch
2 times, most recently
from
82bcb27 to
a767c7c
Compare
xedin
changed the title
|
@swift-ci please build toolchain macOS |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
This was referenced Jun 6, 2023
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test |
This instruction is similar to AssignByWrapperInst, but instead of having a destination operand, the initialization is fully factored into the init function operand. Like AssignByWrapper, AssignOrInit has partial application operands of both the initializer and the setter, and DI will lower the instruction to a call based on whether the assignment is initialization or a setter call.
… into context before checking `initialValue`
…itializes(...)` and accesses(...)`
…initializers Properties with init accessors are used in place of properties they are supposed to initialize in order of stored properties.
…e separated by comma
…nstead of initialization Some properties from `initializes(...)` list could be already initialized, which means that Raw SIL lowering has to emit `destroy_addr` for them before calling init accessor.
DI marks all of of the previously initialized properties and Raw SIL lowering emits `destroy_addr` before calling init accessor for such properties to destroy previously set value.
…ructions when its known
…ly iniitalized properties Properties that are marked as initialized are printed as `[assign=<index>]` where `<index>` point to the property position in `getInitializedProperties()` list.
Because the feature is experimental and the flag would not be present in the production compilers.
…ter Raw SIL lowering
…urations of init accessors
xedin
requested review from
ahoppen,
bnbarham,
rintaro,
hborla,
slavapestov,
AnthonyLatsis,
CodaFi,
DougGregor,
adrian-prantl and
tshortli
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
Unrelated lldb test failure. |
|
@swift-ci please clean test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.